Flink: Set generator parallelism to match input in DynamicIcebergSink#15849
Merged
pvary merged 1 commit intoapache:mainfrom Apr 17, 2026
Merged
Flink: Set generator parallelism to match input in DynamicIcebergSink#15849pvary merged 1 commit intoapache:mainfrom
pvary merged 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
Thanks for the review! |
mxm
approved these changes
Apr 12, 2026
Contributor
mxm
left a comment
There was a problem hiding this comment.
Normally, we do the latest Flink version first, and then backport to the other versions, but the changes here are easy enough to review.
LGTM. Thanks @sachinnn99!
Contributor
|
CC @pvary |
pvary
approved these changes
Apr 17, 2026
Contributor
|
Merged to main. |
Member
|
It looks this PR did not rebase on #15433 and brought in a test regression. #16026 has been submitted to fix it. |
Contributor
Author
Contributor
Author
|
@manuzhang Thanks for catching this and submitting #16026 to fix it. Apologies for the regression — I should have rebased on #15433 before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynamicRecordProcessor(generator) operator parallelism to match upstream input parallelism inDynamicIcebergSink.Builder.append()IcebergSinkandFlinkSinkCloses #15827
Test plan
testGeneratorDefaultParallelisminTestDynamicIcebergSink(all 3 Flink versions)testOperatorUidsFormatstill passes