Open-API: Align requiresNamespaceCreate default with README documentation#15997
Open
swjtu-zhanglei wants to merge 1 commit intoapache:mainfrom
Open
Open-API: Align requiresNamespaceCreate default with README documentation#15997swjtu-zhanglei wants to merge 1 commit intoapache:mainfrom
swjtu-zhanglei wants to merge 1 commit intoapache:mainfrom
Conversation
swjtu-zhanglei
force-pushed
the
main
branch
2 times, most recently
from
9411b18 to
4791aa6
Compare
swjtu-zhanglei
force-pushed
the
main
branch
2 times, most recently
from
4d13a98 to
bd29fab
Compare
…tion The README.md documents that rck.requires-namespace-create defaults to true, but the code was using super.requiresNamespaceCreate() as fallback which returns false from CatalogTests. This change makes the default value consistent with the documented behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README.md documents that rck.requires-namespace-create defaults to true, but the code was using super.requiresNamespaceCreate() as fallback which returns false from CatalogTests. This change makes the default value consistent with the documented behavior.