Flink: Parallelize writer flush in DynamicWriter.prepareCommit#16015
Open
lrsb wants to merge 1 commit intoapache:mainfrom
Open
Flink: Parallelize writer flush in DynamicWriter.prepareCommit#16015lrsb wants to merge 1 commit intoapache:mainfrom
lrsb wants to merge 1 commit intoapache:mainfrom
Conversation
DynamicWriter.prepareCommit() flushed each TaskWriter sequentially on the Flink task thread. When many schemas / write targets are active at checkpoint time this makes checkpointing latency dominated by the sum of all per-writer flush times, and the task thread is blocked on IO throughout. Submit each TaskWriter.complete() call to a per-subtask fixed-size thread pool and wait for all futures to join before collecting results. Metrics recording stays sequential after the join because DynamicWriterMetrics is not thread-safe.
Contributor
|
@lrsb: We usually create the PR against the newest version of Flink, and when that is reviewed and merged then backport the change to the older Flink version. |
Author
|
Will fix, thanks for bringing this up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16014
DynamicWriter.prepareCommit() flushed each TaskWriter sequentially on the Flink task thread. When many schemas / write targets are active at checkpoint time this makes checkpointing latency dominated by the sum of all per-writer flush times, and the task thread is blocked on IO throughout.
Submit each TaskWriter.complete() call to a per-subtask fixed-size thread pool and wait for all futures to join before collecting results. Metrics recording stays sequential after the join because DynamicWriterMetrics is not thread-safe.