feat(server): return base_offset and partition_id from send_messages#3101
Open
sujitn wants to merge 2 commits intoapache:masterfrom
Open
feat(server): return base_offset and partition_id from send_messages#3101sujitn wants to merge 2 commits intoapache:masterfrom
sujitn wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3101 +/- ##
============================================
- Coverage 72.75% 72.73% -0.02%
Complexity 943 943
============================================
Files 1117 1117
Lines 96343 96335 -8
Branches 73544 73552 +8
============================================
- Hits 70091 70067 -24
+ Misses 23704 23703 -1
- Partials 2548 2565 +17
🚀 New features to boost your workflow:
|
b3ad595 to
ee34994
Compare
tungtose
reviewed
Apr 13, 2026
core/server/src/binary/handlers/messages/send_messages_handler.rs
Outdated
Show resolved
Hide resolved
265d6be to
d2b2e3d
Compare
hubcio
requested changes
Apr 13, 2026
core/server/src/binary/handlers/messages/send_messages_handler.rs
Outdated
Show resolved
Hide resolved
The offset assigned during append was computed but discarded. Propagate it through ShardResponse::SendMessages and include it in the binary protocol response. Wire format change: Before: [status:4 LE][length:4 LE (0)] After: [status:4 LE][length:4 LE (12)][base_offset:8 LE][partition_id:4 LE] Backwards compatible — existing SDK clients read the length field and skip unknown body bytes. The send_messages wrapper discards the response body and returns Ok(()). Ref: apache#3044
703510e to
a685301
Compare
Contributor
|
I'm gonna review this properly once we finalize current release 0.8.0. |
atharvalade
approved these changes
Apr 14, 2026
Contributor
|
I think we should at least create issues for every sdk to implement that change in api (just after merge) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The offset assigned during append was computed but discarded. Propagate it through ShardResponse::SendMessages and include it in the binary protocol response.
Wire format change:
Before: [status:4 LE][length:4 LE (0)]
After: [status:4 LE][length:4 LE (12)][base_offset:8 LE][partition_id:4 LE]
existing SDK clients (excluding node) read the length field and skip unknown body bytes. The send_messages wrapper discards the response body and returns Ok(()).
Fixed node SDK to ignore length
Ref: #3044
Local Execution
AI Usage
If AI tools were used, please answer:
Which tools?
Claude
Scope of usage?
SDK validation
How did you verify the generated code works correctly?
Yes