IGNITE-27012 Improve partition API #7091
Conversation
ptupitsyn
changed the title
modules/api/src/main/java/org/apache/ignite/table/partition/PartitionDistribution.java
Outdated
Show resolved
Hide resolved
...les/client/src/main/java/org/apache/ignite/internal/client/table/ClientPartitionManager.java
Outdated
Show resolved
Hide resolved
|
@ptupitsyn Should we change the type for the partition ID from int to long? I see changes in #7111, but how it will work for PartitionDistribution#partitions, PartitionDistribution#primaryReplicas() if it uses HashMap, ArrayList with size int. |
|
@nva yes, partition id should be
We don't expect a huge number of partitions so this should not be a problem. |
.idea/codeStyles/Project.xml
Outdated
| </option> | ||
| </AndroidXmlCodeStyleSettings> | ||
| <JSCodeStyleSettings> | ||
| <JSCodeStyleSettings version="0"> |
There was a problem hiding this comment.
Should we revert those entire file? Not sure what those changes mean.
| Map<Partition, ClusterNode> primaryReplicas(); | ||
|
|
||
| /** | ||
| * Gets all partitions hosted by the specified node as a primary replica. |
There was a problem hiding this comment.
| * Gets all partitions hosted by the specified node as a primary replica. | |
| * Gets all partitions hosted by the specified node as a primary replica as of the time of the call. | |
| * | |
| * <p>Note: This assignment may become outdated if a re-assigment happens on the cluster. |
| return partitionId; | ||
| } | ||
|
|
||
| @Deprecated(since = "3.2", forRemoval = true) |
There was a problem hiding this comment.
This class is not in the public API so we can just remove the old thing.
2 participants
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes