IGNITE-27212 - Complete automation for compute deployment unit; Minor bug fixes #7122

ashishm07 · 2025-12-01T14:35:13Z

Deployment Unit - Complete automation and standardization of all examples containing Deployment Unit
Minor bug fixes to support complete automation.

Tested on : apacheignite/ignite:3.1.0

Repo : https://github.com/apache/ignite-3/tree/main/examples

Absolute Path of affected files :

examples/java/src/main/java/org/apache/ignite/example/compute/* – All files under compute

examples/java/src/main/java/org/apache/ignite/example/code/deployment/CodeDeploymentExample.java

examples/java/src/main/java/org/apache/ignite/example/serialization/SerializationExample.java

examples/java/src/main/java/org/apache/ignite/example/streaming/DistributedComputeWithReceiverExample.java

examples/java/src/main/java/org/apache/ignite/example/streaming/MultiTableDataStreamerExample.java

Sample Error :
Exception in thread "main" org.apache.ignite.compute.ComputeException: IGN-COMPUTE-9 Job execution failed: java.lang.ClassNotFoundException: org.apache.ignite.example.compute.ComputeColocatedExample$PrintAccountInfoJob. Deployment unit computeExampleUnit:1.0.0 doesn't exist TraceId:e232314f

Solution : Completely automated deployment unit dependent examples and made minor bug fixes to support the same

iartiukhov · 2025-12-03T08:25:53Z

examples/java/src/main/java/org/apache/ignite/example/compute/ComputeJobPriorityExample.java

     * High-priority job.
     */
-    private static class HighPriorityJob implements ComputeJob<Integer, String> {
+    public static class HighPriorityJob implements ComputeJob<Integer, String> {


What's the reason behind changing the visibility scope? Here and in all other implementations of ComputeJob.

Made it public/static so Ignite can access and create the job class remotely without instantiation errors.
DeploymentUnit is not able to find these jobs unless we make it accessible remotely

iartiukhov · 2025-12-03T08:27:53Z

examples/java/src/main/java/org/apache/ignite/example/serialization/AutoSerializableArg.java

@@ -1,33 +1,28 @@
-/*


Please keep the header with licensing info.

Have added the licensing info back.

iartiukhov · 2025-12-03T08:28:55Z

examples/java/src/main/java/org/apache/ignite/example/code/deployment/MyJob.java

        }
    }
-}
+}


No reason to change this file. Please revert it (keep existing newlines).

Reverted to original.

Let's revert the file completely.

examples/java/src/main/java/org/apache/ignite/example/compute/ComputeBroadcastExample.java

IgGusev · 2025-12-08T08:40:07Z

examples/java/src/main/java/org/apache/ignite/example/compute/ComputeAsyncExample.java


            System.out.println("\nConfiguring compute job...");

+            // 1) Check if deployment unit already exists


What is step 2?

Removing all comments as previously advised

IgGusev · 2025-12-08T08:40:47Z

examples/java/src/main/java/org/apache/ignite/example/compute/ComputeBroadcastExample.java

+
            System.out.println("\nConfiguring compute job...");

+            // 1) Check if deployment unit already exists


Removing all comments as previously advised

xtern · 2025-12-08T14:54:16Z

examples/java/src/main/java/org/apache/ignite/example/table/MapperExample.java

+                Statement stmt = conn.createStatement()
+        ) {
+
+            stmt.executeUpdate("DROP TABLE IF EXISTS Person");


I think this is a bad practice, an example must not delete tables that it did not create.

Suggestion received. Reverted unintended file addition - The file is being handled in a separate PR : #7103

xtern · 2025-12-08T14:57:12Z

examples/java/src/main/java/org/apache/ignite/example/table/MapperExample.java

+            stmt.executeUpdate("DROP TABLE IF EXISTS Person");
+
+            stmt.executeUpdate(
+                    "CREATE TABLE IF NOT EXISTS Person ("


I think we should avoid using IF NOT EXISTS/IF EXISTS if the table already exists - the example shouldn't work because the table schema might be different and we'll get confusing errors.

Suggestion received. Reverted unintended file addition - The file is being handled in a separate PR : #7103

...a/src/main/java/org/apache/ignite/example/code/deployment/AbstractDeploymentUnitExample.java

examples/java/src/main/java/org/apache/ignite/example/util/DeployComputeUnit.java

examples/java/src/main/java/org/apache/ignite/example/serialization/AutoSerializableArg.java

examples/java/src/main/java/org/apache/ignite/example/serialization/SerializationExample.java

examples/java/src/main/java/org/apache/ignite/example/compute/ComputeAsyncExample.java

...a/src/main/java/org/apache/ignite/example/code/deployment/AbstractDeploymentUnitExample.java

examples/java/src/main/java/org/apache/ignite/example/compute/ComputeBroadcastExample.java

examples/java/src/main/java/org/apache/ignite/example/compute/ComputeCancellationExample.java

ashishm07 added 7 commits November 27, 2025 14:37

IGNITE-27171: Fixed MapperExample failures

0c7212a

Merge branch 'main' of https://github.com/apache/ignite-3

36dcf54

IGNITE-27212 : Compute Example Complete Automation; Minor bug fixes

c57e4cb

IGNITE-27212 : CodeDeployment.java fixes

3c174db

IGNITE-27212 : PMD fixes

d32e518

IGNITE-27212 : Javadoc fixes

fa86f46

IGNITE-27212 : Javadoc fixes

ffcfa2b

ashishm07 force-pushed the IGNITE-27212 branch from d32e518 to ffcfa2b Compare December 2, 2025 11:23

iartiukhov reviewed Dec 3, 2025

View reviewed changes

ashishm07 added 2 commits December 5, 2025 18:20

IGNITE-27212 : Resolve PR review comments and apply suggested changes

296a644

Merge detached branch into IGNITE-27212

2db2fb1

IgGusev reviewed Dec 8, 2025

View reviewed changes

xtern reviewed Dec 8, 2025

View reviewed changes

iartiukhov mentioned this pull request Dec 9, 2025

IGNITE-27171: Fixed MapperExample failure #7103

Merged

iartiukhov suggested changes Dec 9, 2025

View reviewed changes

ashishm07 and others added 4 commits December 9, 2025 14:07

IGNITE-27212 : Resolve PR review comments and apply suggested changes

a616aba

IGNITE-27212 : PR Review changes; Remove unused imports

142a58b

Merge branch 'main' into IGNITE-27212

85c1270

IGNITE-27212 : code cleanup

aacaa41


		System.out.println("\nConfiguring compute job...");

		// 1) Check if deployment unit already exists

IGNITE-27212 - Complete automation for compute deployment unit; Minor bug fixes #7122

Are you sure you want to change the base?

IGNITE-27212 - Complete automation for compute deployment unit; Minor bug fixes #7122

Conversation

ashishm07 commented Dec 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants