fix(desktop): show archived actions inline - #4375
Open
Phoenix500526 wants to merge 2 commits into
Open
Conversation
Phoenix500526
force-pushed
the
fix/archived-task-icon-actions
branch
from
August 31, 2026 15:45
4f2d198 to
daae984
Compare
Archived task rows mixed a text action with a one-item overflow menu. Direct icon actions make both choices visible without redundant chrome. CLOSES apache#4370 Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
Phoenix500526
force-pushed
the
fix/archived-task-icon-actions
branch
2 times, most recently
from
September 1, 2026 07:25
daae984 to
6189e6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Archived task rows exposed Restore as a text button while hiding their only
other action, Delete, behind an overflow menu. Show both actions directly as
compact icon buttons, rename Restore to the more precise Unarchive, and use a
matched Archive/Unarchive icon pair so the inverse relationship is visible.
The existing permanent-delete confirmation and task cleanup flow are unchanged.
Fixes #4370
Verification
npm run format:check -- apps/desktop/e2e/parent-session-deletion.spec.ts apps/desktop/src/renderer/locales/settings-tasks-copy.ts apps/desktop/src/renderer/settings/tasks-settings-page.tsx packages/ui/src/__tests__/icons.test.tsx packages/ui/src/icons.tsx— passednpm --workspace @maka/ui run typecheck— passednpm --workspace @maka/desktop run typecheck— passednpm --workspace @maka/ui run build— passednode --test packages/ui/dist/__tests__/icons.test.js— 1 test passedapps/desktop/e2e/parent-session-deletion.spec.ts; CI is pendingBefore Change
After Change
AI use
Select exactly one:
Tool(s) and scope: Codex — implementation, tests, and PR preparation.
Checklist
Does this PR entail a change in behavior?