fix(cli): preserve unresolved sandbox failures across unrelated tools - #4389
Open
jsiu93 wants to merge 1 commit into
Open
fix(cli): preserve unresolved sandbox failures across unrelated tools#4389jsiu93 wants to merge 1 commit into
jsiu93 wants to merge 1 commit into
Conversation
Track the failed tool name with each unresolved sandbox failure. Require a later success from that tool before classifying boundary recovery. Generated-by: pi (gpt-5.6-sol)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Track the failed tool name with each unresolved sandbox failure. A later success now proves recovery only when it comes from the same tool in a different Step. An unrelated
tool_searchleaves a failedReadunresolved, so non-interactive boundary denial returns exit code1with empty stdout.Fixes #4388
Verification
Before the fix, the failing assertion received exit code
0; it expected1.A live CLI run against the patched build returned
1after 21 seconds, kept stdout empty, and retained the non-interactive sandbox boundary diagnostic on stderr.AI use
Select exactly one:
Tool(s) and scope: pi (gpt-5.6-sol), human-reviewed
Checklist
Does this PR entail a change in behavior?