Preserve security key signature blobs#902
Merged
tomaswolf merged 1 commit intoJun 21, 2026
Merged
Conversation
tomaswolf
reviewed
Jun 19, 2026
tomaswolf
reviewed
Jun 19, 2026
303a134 to
f463789
Compare
Member
|
Thanks a lot. I've added an integration test in a follow-up commit. |
Contributor
Author
|
Glad it helps! Thanks for such a responsive review. Looking forward to be the part of Apache community. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security-key (
sk-*) signatures carry a structured OpenSSH signature blob: algorithm, raw signature, flags, and counter. The client-side auth path and OpenSSH agent proxy path were treating those like ordinary two-field signatures, which dropped or double-wrapped the trailing security-key fields.This change preserves the full security-key signature blob when reading OpenSSH agent responses, forwarding local agent responses, and appending the final userauth signature. Ordinary key types keep the existing algorithm-plus-signature wrapping.
Tests cover both sides of the client path:
AgentUnitTest.securityKeySignatureBlobverifies a security-key signature blob survives the agent protocol path with flags and counter intact.UserAuthPublicKeySkTest.securityKeySignatureBlobIsNotWrappedverifies the client userauth packet writes the security-key signature blob directly instead of wrapping it again.Validation:
./mvnw -pl sshd-core -am -Dtest=AgentUnitTest,UserAuthPublicKeySkTest -Dsurefire.failIfNoSpecifiedTests=false test