When loading the help class for watches, use MethodHandles.Lookup.defineHiddenClass where available. #9094
+117
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugger evaluates watches, it sometimes interprets the watch, but if the watch is too complex, it will synthetize a class with the watch, compile, load and execute it.
But consider a case where there's a method like:
and the watch is like:
the watch evaluation fails, as the synthetized class is not part of the
EvalAppnest, and debugger simply loads the class using the ClassLoader as any other class.The draft here tries to use
Lookup.defineHiddenClass, which allows to inject the class into the nest, and also hopefully allows the class to be unloaded faster.It falls back to the original behavior if
defineHiddenClassis not available in the debugee, but could also useUnsafe.defineAnonymousClass:https://github.com/openjdk/jdk11u-dev/blob/705236baf53a76f0beb7be29fe45b68b7999fc7e/src/jdk.unsupported/share/classes/sun/misc/Unsafe.java#L829
although I am personally not really particular about targets that don't have
defineHiddenClass.^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)