Merged
Conversation
luoyuxia
force-pushed
the
introduce-table-read-builder-final
branch
from
a905a3c to
4c7c645
Compare
| } | ||
|
|
||
| /// Create a table read for consuming splits (e.g. from a scan plan). | ||
| pub fn new_read(self) -> Result<TableRead<'a>> { |
There was a problem hiding this comment.
In Java Paimon and pypaimon, ReadBuilder can call both newScan() and newRead() from the same builder instance. Can you please double check here ?
Contributor
Author
There was a problem hiding this comment.
Do you mean the ownership move which prevent it call newScan and newRead in a same instance.
Now, I change to use &self which should be good then
Contributor
Author
|
@XiaoHongbo-Hope Thanks for your reviewing. Comments has been addressed. |
XiaoHongbo-Hope
approved these changes
Mar 10, 2026
|
+1 |
1 similar comment
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #113
Brief change log
Tests
API and Format
Documentation