-
Notifications
You must be signed in to change notification settings - Fork 479
Update wording in Geospatial spec #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
milastdbx
wants to merge
13
commits into
apache:master
Choose a base branch
from
milastdbx:updateGeoSpec
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c5773cb
Updated geospatial doc
milastdbx c4e09d0
update
milastdbx 35826b0
update
milastdbx 825be53
Apply suggestions from code review
milastdbx 2d7723a
Apply suggestion from @milastdbx
milastdbx 3ba139a
Apply suggestions from code review
milastdbx a1d8af6
Apply suggestion from @milastdbx
milastdbx ead9261
Apply suggestion from @milastdbx
milastdbx 0ffb80d
Apply suggestion from @mkaravel
milastdbx 5cc2083
Apply suggestion from @milastdbx
milastdbx d5959dc
Update Geospatial.md
milastdbx 86e754f
Update Geospatial.md
milastdbx 5a3a572
Update Geospatial.md
milastdbx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so readers first have to determine if the value is a valid projjson? And if it isn't that try to parse the key-value pair (or vice versa)? Maybe we should be explicit about this guidance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those two formats specifically I don't think there would ever be a difference between the parse order (a ~9 character colon-separated string and a few kilobytes of valid JSON).