Skip to content

GH-561: variant schema examples to use (VARIANT(1))#562

Merged
alamb merged 2 commits intoapache:masterfrom
steveloughran:pr/GH-561-variant-1
Apr 4, 2026
Merged

GH-561: variant schema examples to use (VARIANT(1))#562
alamb merged 2 commits intoapache:masterfrom
steveloughran:pr/GH-561-variant-1

Conversation

@steveloughran
Copy link
Copy Markdown
Contributor

@steveloughran steveloughran commented Mar 31, 2026

What changes are included in this PR?

Fix schema examples and in logical types doc declare that the version number is required.

Do these changes have PoC implementations?

Well, without the change parquet-java doesn't compile schemas.

…NT(1))

Fix schema examples and in logical types doc declare that the version number is required.
@steveloughran steveloughran changed the title GH-561: variant schema examples use (VARIANT) rather than (VARIANT(1)) GH-561: variant schema examples to use (VARIANT(1)) Mar 31, 2026
@steveloughran
Copy link
Copy Markdown
Contributor Author

Thanks. I suspect I may have been the first person trying to write schemas containing variants using the specification documentation, maybe at all.

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steveloughran and @wgtmac

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Copy link
Copy Markdown
Contributor

@aihuaxu aihuaxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it.

@alamb alamb merged commit 96656a5 into apache:master Apr 4, 2026
4 checks passed
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 4, 2026

Thanks again everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

variant schema examples use (VARIANT) rather than (VARIANT(1))

5 participants