Repository navigation
Avoid implicit narrowing compound assignments in SchemaTypeSystemImpl.nextBytes - #129
Merged
Merged
Conversation
….nextBytes Fixes code-scanning alerts for java/implicit-cast-in-compound-assignment. Also mix the system-info bytes (not just their index) into the mask, and index the mask with % rather than & so all mask bytes are used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes code-scanning alerts #6 and #7 (
java/implicit-cast-in-compound-assignment) inSchemaTypeSystemImpl.nextBytes. The byte wraparound is intended, so the twobytecompound assignments are now one assignment with an explicit(byte)cast.While there, two fixes in the same method. Both affect only how random the generated type-system names are:
iand never readbytes[i], so the mask depended only on how many bytes of system info there were, not on their content.i & _mask.length(i & 16), which is always 0 for i in 0..15, so only_mask[0]was ever applied. It is nowi % _mask.length, like the earlier loop.Alerts #1–#5 (
GDurationBuilder,GDateBuilder,PushedInputStream) were raised against an older commit and are already fixed on trunk, so they should close on the next scan.🤖 Generated with Claude Code