Repository navigation
fix(google): default external account credential format to text - #910
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External account credential files generated by gcloud can omit
credential_source.format. Reqsign currently rejects those files, allowing the default credential chain to fall back to VM metadata instead of using the configured identity.Default omitted formats to plain text for both file and URL sources, as required by AIP-4117. Explicit text and JSON formats retain their existing behavior, and malformed explicit formats remain errors.
The regression test exercises
GOOGLE_APPLICATION_CREDENTIALSthrough the default provider, verifies the subject token sent to mocked STS, and rejects metadata fallback. It reproduced the fallback before the fix and passes afterward for both source types; live cloud exchange was not tested.Fixes #909.