Conversation
📝 WalkthroughWalkthroughUpdates to CI and dev-tooling: bump Node.js in the release workflow to 24.15.0, replace several catalog-based devDependency entries with explicit semver versions, adjust pnpm workspace catalog entries and mode, and reformat JSON arrays in schema.json without semantic changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bzp2010
added
the
test/apisix-standalone
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/release.yaml (1)
17-21: Deduplicate Node version to a single workflow-level variable.This avoids future version skew between setup and build env blocks.
♻️ Suggested refactor
name: Release +env: + NODE_VERSION: "24.15.0" on: push: @@ - uses: actions/setup-node@v6 with: - node-version: "24.15.0" + node-version: "${{ env.NODE_VERSION }}" @@ - name: Build ADC env: - NODE_VERSION: "24.15.0" + NODE_VERSION: "${{ env.NODE_VERSION }}" @@ - uses: actions/setup-node@v4 with: - node-version: "24.15.0" + node-version: "${{ env.NODE_VERSION }}" @@ - name: Build ADC env: - NODE_VERSION: "24.15.0" + NODE_VERSION: "${{ env.NODE_VERSION }}"Also applies to: 65-69
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yaml around lines 17 - 21, Define a single workflow-level variable for the Node version and reference it everywhere instead of hardcoding "24.15.0"; for example add an env entry like NODE_VERSION at the top-level and replace both occurrences of node-version: "24.15.0" (used with pnpm/action-setup@v4) and the NODE_VERSION value inside the Build ADC step (and the other similar block around lines 65-69) with references to that top-level variable (e.g. use the workflow env variable via ${{ env.NODE_VERSION }}), ensuring all steps consistently use the same identifier.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/release.yaml:
- Around line 17-21: Define a single workflow-level variable for the Node
version and reference it everywhere instead of hardcoding "24.15.0"; for example
add an env entry like NODE_VERSION at the top-level and replace both occurrences
of node-version: "24.15.0" (used with pnpm/action-setup@v4) and the NODE_VERSION
value inside the Build ADC step (and the other similar block around lines 65-69)
with references to that top-level variable (e.g. use the workflow env variable
via ${{ env.NODE_VERSION }}), ensuring all steps consistently use the same
identifier.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6b5508c1-0e90-4c0b-ba10-e39ee82dcaaa
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
.github/workflows/release.yamlpackage.jsonpnpm-workspace.yamlschema.json
guoqqqi
approved these changes
Apr 22, 2026
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/release.yaml (1)
65-71: Align action major versions between jobs to avoid cross-platform release differences.The
adc-macosjob usesactions/setup-node@v4andpnpm/action-setup@v2, while theadcjob usesv6andv4respectively. These should be kept in sync.Proposed alignment
- - uses: actions/setup-node@v4 + - uses: actions/setup-node@v6 ... - - uses: pnpm/action-setup@v2 + - uses: pnpm/action-setup@v4🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yaml around lines 65 - 71, The workflow uses mismatched action major versions between jobs (adc-macos uses actions/setup-node@v4 and pnpm/action-setup@v2 while adc uses actions/setup-node@v6 and pnpm/action-setup@v4); update the adc-macos job to use the same major versions as the adc job (or vice versa) so both jobs reference the same action versions for actions/setup-node and pnpm/action-setup (ensure you change the uses entries in the adc-macos and adc job steps to the chosen aligned major version numbers).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/release.yaml:
- Around line 65-71: The workflow uses mismatched action major versions between
jobs (adc-macos uses actions/setup-node@v4 and pnpm/action-setup@v2 while adc
uses actions/setup-node@v6 and pnpm/action-setup@v4); update the adc-macos job
to use the same major versions as the adc job (or vice versa) so both jobs
reference the same action versions for actions/setup-node and pnpm/action-setup
(ensure you change the uses entries in the adc-macos and adc job steps to the
chosen aligned major version numbers).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3c849747-3258-46be-bd7c-376d11b53aa8
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
.github/workflows/release.yamlpnpm-workspace.yaml
✅ Files skipped from review due to trivial changes (1)
- pnpm-workspace.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade dependencies.
Checklist
Summary by CodeRabbit