Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add aisix Helm chart #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat: add aisix Helm chart #278
Changes from all commits
7fe8cd8cfa3a04d070967e4405650ea1e1b73965e7932d1cda8feeaeeca980e6f0de84c4cbbc9File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 198
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 1180
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 1462
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 914
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 115
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 493
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 1101
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 88
🏁 Script executed:
# Check if there are any existing patterns of conditional config blocks in the configmap cat -n charts/aisix/templates/configmap.yamlRepository: api7/api7-helm-chart
Length of output: 1180
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 88
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 46
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 46
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 46
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 46
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 158
🏁 Script executed:
Repository: api7/api7-helm-chart
Length of output: 2909
Conditionally render admin config block to match admin.enabled flag.
The
server.admin.listenconfiguration is always included in the ConfigMap, even when.Values.admin.enabledisfalse. This creates an inconsistency: the Service, Ingress, and container port are properly gated by theadmin.enabledflag elsewhere in the chart (as seen in service-admin.yaml, ingress-admin.yaml, and deployment.yaml), but the configuration block itself is not. To maintain consistency and avoid potential configuration validation issues in AISIX, wrap the admin block conditionally:server: proxy: listen: "{{ .Values.gateway.ip }}:{{ .Values.gateway.containerPort }}" tls: enabled: false + {{- if .Values.admin.enabled }} admin: listen: "{{ .Values.admin.ip }}:{{ .Values.admin.containerPort }}" + {{- end }}🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.