feat: add key-value record public URL - #669
Open
AkhilTrivediX wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyValueStore.getRecordPublicUrl()for remote key-value storesapify-clientmethodgetPublicUrl()API while keeping it availableWhy
The SDK constructed record URLs itself, duplicating logic that now belongs in
apify-client. The new asynchronous method exposes the client-backed path and keeps local-store behavior unchanged.Closes #433
Validation
corepack pnpm test(127 passed, 14 skipped)corepack pnpm vitest run test/apify/key_value_store.test.ts --silentcorepack pnpm compilecorepack pnpm lintcorepack pnpm exec oxfmt --check src/key_value_store.ts test/apify/key_value_store.test.tsgit diff --check