Skip to content

Add note about .edu email. Add question for funding identifier#187

Merged
NEStock merged 6 commits into
apl-setupfrom
184-update-account-setup-page-to-add-additional-ember-specific-information
May 29, 2026
Merged

Add note about .edu email. Add question for funding identifier#187
NEStock merged 6 commits into
apl-setupfrom
184-update-account-setup-page-to-add-additional-ember-specific-information

Conversation

@NEStock

@NEStock NEStock commented May 27, 2026

Copy link
Copy Markdown
Member

Changes

  • Added a note about using a .edu email address for your primary GitHub email for faster approval
    • note: I am not sure how much this will actually help, as this form appears after the user has already authenticated with GitHub
  • Updated "Affiliation(s)" question to be "Academic Affiliation(s)" (to satisfy our follow-up question 1)
  • Added a question asking for funding identifier (to satisfy our follow-up question 2)
Screenshot 2026-05-28 at 4 58 05 PM

Testing

  • checkout the branch, run both the frontend and backend of dandi-archive
  • you may need to change line 91 in auth.py (LOCALLY ONLY) to see the form while running locally, as the local login process does not use GitHub and thus appears a little different
-            f'?{request.META["QUERY_STRING"]}&QUESTIONS={json.dumps(COLLECT_USER_NAME_QUESTIONS)}'
+            f'?{request.META["QUERY_STRING"]}&QUESTIONS={json.dumps(NEW_USER_QUESTIONS)}'

Notes

@NEStock NEStock linked an issue May 27, 2026 that may be closed by this pull request
@netlify

netlify Bot commented May 27, 2026

Copy link
Copy Markdown

Deploy Preview for ember-dandi-archive ready!

Name Link
🔨 Latest commit 21b73e2
🔍 Latest deploy log https://app.netlify.com/projects/ember-dandi-archive/deploys/6a199be1609e0300086230b7
😎 Deploy Preview https://deploy-preview-187--ember-dandi-archive.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@NEStock NEStock force-pushed the 184-update-account-setup-page-to-add-additional-ember-specific-information branch 2 times, most recently from 6710fed to e7cfea8 Compare May 28, 2026 19:21
@NEStock NEStock marked this pull request as ready for review May 28, 2026 19:54
@NEStock NEStock force-pushed the 184-update-account-setup-page-to-add-additional-ember-specific-information branch from e7cfea8 to 0fe600f Compare May 28, 2026 19:54
brianhelba and others added 3 commits May 28, 2026 16:22
RabbitMQ 4.3 disallows a queue configuration (non-exclusive,
non-durable) that Celery is still using by default. Celery
creates such queues for:
* remote control (`pidbox`)
* events (`celeryev`)

To disable the (remote) control queue:
* `--without-mingle`
* `worker_enable_remote_control = False`

To disable the events queue:
* `--without-heartbeat`
* `--without-gossip`
* `worker_send_task_events = False` (already the default)

Note, gossip, mingle, and heartbeat features provide no
value. They generate extra traffic and are only used for
task revocation (which DANDI doesn't use) and worker
monitoring.
The "Develop Natively" section was missed by c10a585. Without
--without-mingle and --without-gossip, the worker tries to declare
non-exclusive, non-durable pidbox and celeryev queues, which
RabbitMQ 4.3 rejects.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@NEStock NEStock self-assigned this May 28, 2026
@NEStock NEStock requested review from laurendiaz and sandyhider May 28, 2026 21:03
@NEStock NEStock added the enhancement New feature or request label May 28, 2026
<div class="row">
<div class="col s12">
<b>
Please note that setting your primary email address in GitHub to an academic email (.edu) will enable faster approval.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be nit-picky but maybe say automatic instead of faster approval? it's a bit vague and personally I'd be more inclined to adjust my github for specifically automatic approval but I'm not sure if you necessarily want users to know we have automatic approvals in place

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh that's a good point! will follow-up with that question to the team

@NEStock

NEStock commented May 29, 2026

Copy link
Copy Markdown
Member Author

Merging with cancelled test because the test is stalling in other places and does not seem to be related to this MR specifically

@NEStock NEStock merged commit ea2f38e into apl-setup May 29, 2026
9 of 10 checks passed
@NEStock NEStock deleted the 184-update-account-setup-page-to-add-additional-ember-specific-information branch May 29, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update account setup page to add additional EMBER specific information

4 participants