Add note about .edu email. Add question for funding identifier#187
Merged
NEStock merged 6 commits intoMay 29, 2026
Conversation
✅ Deploy Preview for ember-dandi-archive ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
6710fed to
e7cfea8
Compare
e7cfea8 to
0fe600f
Compare
RabbitMQ 4.3 disallows a queue configuration (non-exclusive, non-durable) that Celery is still using by default. Celery creates such queues for: * remote control (`pidbox`) * events (`celeryev`) To disable the (remote) control queue: * `--without-mingle` * `worker_enable_remote_control = False` To disable the events queue: * `--without-heartbeat` * `--without-gossip` * `worker_send_task_events = False` (already the default) Note, gossip, mingle, and heartbeat features provide no value. They generate extra traffic and are only used for task revocation (which DANDI doesn't use) and worker monitoring.
The "Develop Natively" section was missed by c10a585. Without --without-mingle and --without-gossip, the worker tries to declare non-exclusive, non-durable pidbox and celeryev queues, which RabbitMQ 4.3 rejects. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
laurendiaz
reviewed
May 29, 2026
| <div class="row"> | ||
| <div class="col s12"> | ||
| <b> | ||
| Please note that setting your primary email address in GitHub to an academic email (.edu) will enable faster approval. |
There was a problem hiding this comment.
this might be nit-picky but maybe say automatic instead of faster approval? it's a bit vague and personally I'd be more inclined to adjust my github for specifically automatic approval but I'm not sure if you necessarily want users to know we have automatic approvals in place
Member
Author
There was a problem hiding this comment.
ahh that's a good point! will follow-up with that question to the team
laurendiaz
approved these changes
May 29, 2026
laurendiaz
approved these changes
May 29, 2026
Member
Author
|
Merging with cancelled test because the test is stalling in other places and does not seem to be related to this MR specifically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Notes