Minor compilation fixes - #1116
Open
GabrielGanne wants to merge 10 commits into
Open
Conversation
Member
|
I targeted the latest branch and now I have conflicts. Please resolve. |
Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
It was included by default, but in a conditional block that force-xdp option can cause to disable. Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
__func__ is the standard since c99, it should be safe to use. This silences some pedantic warnings like this one: > ISO C does not support ‘__FUNCTION__’ predefined identifier Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
This silences warning: > warning: ISO C forbids zero-size array ‘dummy’ Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
"x?: y" is a gnu extension that behaves almost the same as "x? x : y". The difference being that x can be evaluated twice, but here this should not change anything. In addition to silencing a warning, I find that I'm more used to this syntax which is easier to read. This silences warning: > warning: ISO C forbids omitting the middle term of a ‘?:’ expression Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
Assisted-by: Claude Opus 4.8 Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
This is to silence warning: > warning: ISO C forbids ‘return’ with expression, in function returning void Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
* replace all timeval with timespec structures continuing the work of commit [1] * rename all "usec" -> "nsec" for coherency (commit [1]): struct timespec have replaced struct timeval. Those are nanosecond precision. * fix configure help string: "timestamp-trace" -> "enable-timestamp-trace" Note that if timestamp-trace is enabled, there's already a tcpreplay test with pps option enabled that will dump a meaningful trace and act as a smoke test for the feature. Refs: [1] 3b0934e Fixes: 3b0934e Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
SP_TYPE_SOCK_RAW is always defined Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
This adds HAVE_LIBXDP as a terminal backend in the injection chain Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
GabrielGanne
force-pushed
the
compilation-fixes
branch
from
August 3, 2026 05:31
12aca94 to
7859e4e
Compare
Contributor
Author
|
I rebased over branch For ref, the commit was GabrielGanne@503ccf5 I' not sure anyone really cares about these warnings anymore since most HW support this now, but it's still worth noting. From what I can tell, the other commits are still relevant (no other commit in the beta branch tries to address the same issue) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sudo make testChanges:
This PR should only contain changes that have no functional impact, and only either fix compilation with some specific configuration option, or with some additional warnings enabled.
Those warnings were found while working on compiling with meson and trying to add
warning_level=3.Since they are all rather small, I'm submitting them in a single PR, but please feel free to pick or reject any number of them or request a separate PR if you prefer.