tcpprep - fix buffer overflow on truncated packets - #995
Merged
fklassen merged 1 commit intoJul 17, 2026
Conversation
check_dst_port() did not check that the dest port could be read for truncated packets. This adds a test that enforces a tiny bit more that strictly necessary: check for the whole l4 header presence instead of just the dport. The whole header is needed overall anyway. This means that tcpprep will fail to classify packets with incomplete l4 headers and fall back to the default classification for those. Fixes: appneta#985 Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
This was referenced Jul 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_dst_port()did not check that the dest port could be read for truncated packets.This adds a test that enforces a tiny bit more that strictly necessary: check for the whole l4 header presence instead of just the dport. The whole header is needed overall anyway.
This means that tcpprep will fail to classify packets with incomplete l4 headers and fall back to the default classification for those.
Fixes: #985