Repository navigation
test(statusline): hold the contended lock in a subprocess, not os.fork - #261
Merged
Merged
Conversation
pytest's process is already multi-threaded, so os.fork() raised a DeprecationWarning about possible deadlocks in the child. A fresh interpreter now holds the flock until the test closes its stdin, which also replaces the 0.3 s sleep with an explicit release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_exclusive_lock_times_out_when_another_process_holds_itusedos.fork()inside pytest's multi-threaded process, which emitsDeprecationWarning: ... use of fork() may lead to deadlocks in the child.subprocess.Popen. It releases theflockwhen the test closes its stdin, replacing the fixed 0.3 s sleep.# type: ignore[attr-defined]thatos.forkneeded for mypy on Windows.Test plan
uv run pytest -q -rw: 3119 passed, 0 warnings (was 1)tests/test_usage_statusline.pywith-W error::DeprecationWarning, 3 runsruff check,ruff format --check,mypy .,scripts/check_file_size.py🤖 Generated with Claude Code