Security: Arbitrary module load and potential RCE in sync-rpc worker protocol#446
Open
tuanaiseo wants to merge 1 commit intoarakoodev:tsfrom
Conversation
The TCP worker accepts an `INIT` message containing `filename`, then performs `require(filePath)` on that path. If an attacker can connect to this worker port, they can load attacker-chosen local modules (or writable files), resulting in arbitrary code execution in the worker process. Affected files: worker.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
|
CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the Arakoo Contributor License Agreement. You can sign the CLA by adding a new comment to this pull request and pasting exactly the following text. I have read the Arakoo CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The TCP worker accepts an
INITmessage containingfilename, then performsrequire(filePath)on that path. If an attacker can connect to this worker port, they can load attacker-chosen local modules (or writable files), resulting in arbitrary code execution in the worker process.Severity:
criticalFile:
JS/wasm/sync-rpc/worker.jsSolution
Do not accept module paths from network input. Replace with a fixed allowlist of pre-registered handlers, bind server to localhost only, add authentication on the socket protocol, and reject absolute/parent-relative paths.
Changes
JS/wasm/sync-rpc/worker.js(modified)Testing