perf(storage): redirect TOS downloads to signed URLs - #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Summary
Redirect full TOS-backed MCAP downloads to short-lived signed TOS URLs instead of proxying the entire file through Keystone. Keep ranged MCAP preview reads on the existing same-origin proxy path.
Motivation
Cloud MCAP downloads are slow because Keystone currently relays the complete object, adding an extra network hop and making Keystone bandwidth and connection lifetime part of the download path.
Changes
Type of Change
Impact Analysis
Breaking Changes
None.
Backward Compatibility
Fully backward compatible. The existing storage endpoint, download-token flow, Range preview behavior, and MinIO path remain available.
Testing
Test Environment
Test Cases
Commands run:
Test Coverage
Performance Impact
Documentation
Additional Notes