fix: polish styling/UX on multiple pages #1436

thisisharsh7 · 2025-12-06T17:01:49Z

This PR includes several UI polish improvements across multiple pages in the frontend, focusing on better spacing, consistent styling, and improved user experience. The changes also include a refactor to the theme hook for more efficient theme/font updates.

Tests

Test compression settings save flow - verify no duplicate toasts
Test appearance settings save - verify theme and font update together
Verify spacing improvements on logs detail, account, and appearance pages
Test accordion border styling on tools and logs pages
Verify architecture diagram link navigates to correct page

Note

Polishes spacing/border styling across pages, updates architecture link, refactors theme hook and appearance settings to save theme and font together, and tightens compression save error handling.

Appearance Settings:
- Replace separate saveTheme/saveFont with unified saveAppearance usage in settings/appearance/page.tsx.
Theme Hook (lib/theme.hook.ts):
- Consolidate theme/font updates into saveAppearance(theme, font); updates backend and localStorage together.
- Remove separate apply/save functions for theme and font; expose saveAppearance.
Compression Settings (cost/compression/page.tsx):
- Restructure handleSave: update org scope first; wrap team updates in try/catch with error toast; set hasChanges after success.
Logs & Tools UI:
- Add spacing (mb-8) to sections in logs/[id]/page.client.tsx.
- Adjust AccordionItem border styling (!border-b) in logs and tools response modifier editor.
Account Settings UI:
- Add vertical spacing container in settings/account/page.tsx.
Navigation:
- Update architecture diagram link from /agents to /profiles.

^{Written by Cursor Bugbot for commit 812d8a7. This will update automatically on new commits. Configure here.}

platform/frontend/src/app/cost/compression/page.tsx

platform/frontend/src/app/settings/appearance/page.tsx

thisisharsh7 · 2025-12-08T11:25:17Z

can you please review it changes have been applied

platform/frontend/src/app/cost/compression/page.tsx

cursor · 2025-12-08T19:57:10Z

platform/frontend/src/app/settings/appearance/page.tsx

+                saveAppearance?.(
+                  currentUITheme || DEFAULT_THEME,
+                  currentUIFont || DEFAULT_FONT,
+                );


Bug: Disabled state checks wrong mutation's pending status

The disabled prop checks updateAppearanceSettingsMutation.isPending, but the actual save operation uses saveAppearance from useOrgTheme, which internally uses a different mutation (updateThemeMutation). Since updateAppearanceSettingsMutation is never called, isPending will always be false, so buttons won't be disabled during the save operation. This allows users to trigger multiple saves simultaneously.

Additional Locations (1)

platform/frontend/src/app/settings/appearance/page.tsx#L118-L119

@thisisharsh7 do you mind verifying is this statement is true/worth addressing here in the code?

well user can't trigger mulitple saves simultaneously since when we are clicking on the save we are already hiding that save container

joeyorlando

overall looks good! Just some minor comments, once those are addressed, I think we can go ahead and get this merged in

joeyorlando · 2025-12-08T19:58:39Z

platform/frontend/src/app/settings/appearance/page.tsx

+                saveAppearance?.(
+                  currentUITheme || DEFAULT_THEME,
+                  currentUIFont || DEFAULT_FONT,
+                );


@thisisharsh7 do you mind verifying is this statement is true/worth addressing here in the code?

platform/frontend/src/app/cost/compression/page.tsx

joeyorlando

also be sure to fix any errors originating from pnpm check:ci 🙂

thisisharsh7 · 2025-12-09T12:01:35Z

@joeyorlando please review it again when get a chance thanks!

joeyorlando · 2025-12-09T12:17:17Z

@joeyorlando please review it again when get a chance thanks!

it looks like there's 1 last failure under platform/frontend.

FWIW if you run pnpm check:ci from the platform directory, it will run the turbo command in platform/package.json (which will run that command for all of the pnpm workspaces under platform); alternatively just run it from a subdirectory of platform like:

cd platform/frontend
pnpm ci:check

thisisharsh7 · 2025-12-09T12:22:29Z

this?

thisisharsh7 · 2025-12-09T12:24:03Z

I run it from the platform directory earlier pnpm check:ci

thisisharsh7 · 2025-12-09T12:26:07Z

@joeyorlando please review it again when get a chance thanks!

it looks like there's 1 last failure under platform/frontend.

FWIW if you run pnpm check:ci from the platform directory, it will run the turbo command in platform/package.json (which will run that command for all of the pnpm workspaces under platform); alternatively just run it from a subdirectory of platform like:
cd platform/frontend
pnpm ci:check

it works now I guess you might have a typo here pnpm check:ci

thisisharsh7 · 2025-12-09T12:30:21Z

thisisharsh7 · 2025-12-09T12:36:37Z

can we make some precommit check like when user commit, it will check all these lints error there only ?

joeyorlando · 2025-12-09T13:09:48Z

yes we plan to add husky/lint-staged in the near-future 🙂

thisisharsh7 · 2025-12-09T13:12:01Z

yeah thanks looking forward to it

cursor · 2025-12-09T13:13:08Z

platform/frontend/src/app/cost/compression/page.tsx

        queryClient.invalidateQueries({ queryKey: ["teams"] });
+      } catch (error) {
+        toast.error("Failed to update team compression settings");
+        throw error; // Re-throw to prevent setHasChanges(false) from running


Bug: Team mode shows conflicting success and error toasts

In team mode, the updateOrganizationMutation.mutateAsync call at line 115 triggers a success toast ("Tool results compression settings updated") when it completes. If the subsequent team updates (lines 122-133) fail, the catch block shows an error toast ("Failed to update team compression settings"). This results in the user seeing both a success toast and an error toast for what appears to be a single save operation, creating confusing and contradictory feedback. The organization update succeeds but team updates fail, leaving the system in a partially saved state while giving mixed signals to the user.

🤖 I have created a release *beep* *boop* --- ## [0.6.25](platform-v0.6.24...platform-v0.6.25) (2025-12-09) ### Features * LLM Proxy - add X-Archestra-Agent-Id header support ([#1477](#1477)) ([909a306](909a306)) ### Bug Fixes * polish styling/UX on multiple pages ([#1436](#1436)) ([68c5364](68c5364)) * smaller bugs ([#1311](#1311)) ([ba2be1f](ba2be1f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: archestra-ci[bot] <222894074+archestra-ci[bot]@users.noreply.github.com>

fix:UI polish multiple pages

6815cc3

joeyorlando reviewed Dec 7, 2025

View reviewed changes

platform/frontend/src/app/cost/compression/page.tsx Outdated Show resolved Hide resolved

platform/frontend/src/app/settings/appearance/page.tsx Outdated Show resolved Hide resolved

refactor: apply review feedback

836be4d

Merge branch 'main' into fix/ui-polish-multiple-pages

184c4f2

joeyorlando changed the title ~~fix:UI polish multiple pages~~ fix: polish styling/UX on multiple pages Dec 8, 2025

cursor bot reviewed Dec 8, 2025

View reviewed changes

joeyorlando reviewed Dec 8, 2025

View reviewed changes

joeyorlando and others added 2 commits December 9, 2025 06:10

Merge branch 'main' into fix/ui-polish-multiple-pages

3d606e0

added error handling for team compression updates

0555979

Merge branch 'main' into fix/ui-polish-multiple-pages

1d2c4d8

joeyorlando and others added 2 commits December 9, 2025 07:40

Merge branch 'main' into fix/ui-polish-multiple-pages

92a5207

fix: resolve linting

e15eaf1

Merge branch 'main' into fix/ui-polish-multiple-pages

812d8a7

cursor bot reviewed Dec 9, 2025

View reviewed changes

joeyorlando merged commit 68c5364 into archestra-ai:main Dec 9, 2025
18 of 31 checks passed

archestra-ci bot mentioned this pull request Dec 9, 2025

chore(main): release platform 0.6.25 #1472

Merged

fix: polish styling/UX on multiple pages #1436

fix: polish styling/UX on multiple pages #1436

Uh oh!

Conversation

thisisharsh7 commented Dec 6, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests

Uh oh!

Uh oh!

Uh oh!

thisisharsh7 commented Dec 8, 2025

Uh oh!

Uh oh!

cursor bot Dec 8, 2025

Choose a reason for hiding this comment

Bug: Disabled state checks wrong mutation's pending status

Uh oh!

joeyorlando Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

thisisharsh7 Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

thisisharsh7 Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

joeyorlando left a comment

Choose a reason for hiding this comment

Uh oh!

joeyorlando Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joeyorlando left a comment

Choose a reason for hiding this comment

Uh oh!

thisisharsh7 commented Dec 9, 2025

Uh oh!

joeyorlando commented Dec 9, 2025

Uh oh!

thisisharsh7 commented Dec 9, 2025

Uh oh!

thisisharsh7 commented Dec 9, 2025

Uh oh!

thisisharsh7 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thisisharsh7 commented Dec 9, 2025

Uh oh!

thisisharsh7 commented Dec 9, 2025

Uh oh!

joeyorlando commented Dec 9, 2025

Uh oh!

thisisharsh7 commented Dec 9, 2025

Uh oh!

cursor bot Dec 9, 2025

Choose a reason for hiding this comment

Bug: Team mode shows conflicting success and error toasts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thisisharsh7 commented Dec 6, 2025 •

edited by cursor bot

Loading

thisisharsh7 commented Dec 9, 2025 •

edited

Loading