Repository navigation
Add header to unpartitioned CSV output - #560
dajiaohuang wants to merge 1 commit into
Conversation
|
@dajiaohuang this design was purposeful. |
|
Thanks for explaining the intended multi-part CSV behavior. I overlooked that the unpartitioned writer produces multiple part files that users concatenate; enabling headers there would repeat header rows and break that workflow. This change is incompatible with the intended output contract, so I am withdrawing and closing PR #560 rather than ask maintainers to resolve it. No further action is needed. |
GitHub issue(s): None; no issue in the frozen review window describes this behavior.
What does this Pull Request do?
saveCsvenabled CSV headers only when--partitionwas supplied. Without partitioning, Spark's CSV writer default omitted the header, so the first output row was data rather than column names. This adds the sameheader=trueoption to the unpartitioned path.How should this be tested?
Run
mvn -B -V -Dtest=CommandLineAppCsvHeaderTest test. The new test creates a tiny synthetic WARC response and checks that both partitioned and unpartitioned CLI CSV output contains the schema header and record.The full
mvn installsuite was not run: this task was constrained to synthetic archive fixtures, while the repository's existing test resources include bundled WARC datasets.Additional Notes
No new dependencies or documentation changes.
Interested parties
None.