Fix sockets not closing properly by connected()#327
Open
indutny wants to merge 1 commit into
Open
Conversation
When checking `client.connected()` it would set `_sock` to `255` internally, but won't actually communicate back to NINA that the fd is closed so it won't be able to be reused.
a30d2fc to
64b0250
Compare
Author
|
Force pushed with my github email and signed the CLA. |
|
Memory usage change @ 64b0250
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking
client.connected()it would set_sockto255internally, but won't actually communicate back to NINA that the fd is closed so it won't be able to be reused.See also: adafruit#18