Skip to content

Fix sockets not closing properly by connected()#327

Open
indutny wants to merge 1 commit into
arduino-libraries:masterfrom
indutny:fix/socket-reuse-upstream
Open

Fix sockets not closing properly by connected()#327
indutny wants to merge 1 commit into
arduino-libraries:masterfrom
indutny:fix/socket-reuse-upstream

Conversation

@indutny

@indutny indutny commented Jun 9, 2026

Copy link
Copy Markdown

When checking client.connected() it would set _sock to 255 internally, but won't actually communicate back to NINA that the fd is closed so it won't be able to be reused.

See also: adafruit#18

@CLAassistant

CLAassistant commented Jun 9, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

When checking `client.connected()` it would set `_sock` to `255`
internally, but won't actually communicate back to NINA that the fd is
closed so it won't be able to be reused.
@indutny indutny force-pushed the fix/socket-reuse-upstream branch from a30d2fc to 64b0250 Compare June 9, 2026 16:39
@indutny

indutny commented Jun 9, 2026

Copy link
Copy Markdown
Author

Force pushed with my github email and signed the CLA.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Memory usage change @ 64b0250

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/PreferencesCounter
flash
% examples/PreferencesCounter
RAM for global variables
% examples/PreferencesValidation
flash
% examples/PreferencesValidation
RAM for global variables
%
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrvidor4000 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/PreferencesCounter<br>flash,%,examples/PreferencesCounter<br>RAM for global variables,%,examples/PreferencesValidation<br>flash,%,examples/PreferencesValidation<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants