Skip to content

fix: bind ops execution to finalized reviewer - #30

Merged
areshand merged 8 commits into
mainfrom
codex/fix-ops-execute-reviewer
Aug 24, 2026
Merged

fix: bind ops execution to finalized reviewer#30
areshand merged 8 commits into
mainfrom
codex/fix-ops-execute-reviewer

Conversation

@areshand

@areshand areshand commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • keep prod-mcp execution generic and bind each operation to the exact reviewed request, Markdown runbook, original goal, and finalized reviewer
  • require an independent read-only ops reviewer before the supervisor can create a KMS-signed permit
  • accept only cosmetic whole-line Markdown wrapping around exact reviewer records and verdicts; embedded prose and rejected verdicts remain invalid
  • apply the same normalization consistently in lifecycle review, runtime status inference, and the final ops execution gate

Validation

  • ./tests/run.sh passed after the lifecycle/runtime marker fix
  • targeted production-shaped ops-verdict test passed
  • GitHub Framework contract tests passed on Linux, macOS, Rust 1.98, Rust 1.85, and Rust 1.80 for commit 4189f68
  • container image published as ghcr.io/areshand/multiagent:sha-4189f68

Production E2E evidence

  • revision 62 reached contract registration, authority approval, generic ops request generation, and independent ops-review acceptance
  • that run exposed a second cosmetic Markdown mismatch at the pre-signing ops gate; no Slack operation was dispatched
  • revision 63 contains the fix and the clean session slack-general-summary-e2e-0824s is active

Remaining gap

  • the clean revision-63 session has finalized contract scout and authority review, but has not yet produced a prod-mcp receipt or final Slack summary
  • therefore KMS signing, Slack history retrieval, four-section caller response, and final S3 evidence are not yet claimed as complete

@areshand
areshand merged commit 38cc473 into main Aug 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant