Augment iAudioTrack with useful state change events#117
Open
codinronan wants to merge 5 commits intoarielfaur:3.0from
Open
Augment iAudioTrack with useful state change events#117codinronan wants to merge 5 commits intoarielfaur:3.0from
codinronan wants to merge 5 commits intoarielfaur:3.0from
Conversation
|
@codinronan thanks for reviewing my intents. This is exactly what I wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, for change detection reasons my app needs access to these state changes so that I don't have to use setInterval. I need to be able to implement the OnPush change detection strategy, which is extremely hard when a setInterval is needed to detect changes to these objects.
The following events are added to IAudioTrack and implemented in both classes:
This also incorporates #115 so you'll see the same set of changes.
@arielfaur let me know what you think. I'm not convinced this is the best implementation but it is the most obvious.