-
Notifications
You must be signed in to change notification settings - Fork 2
Update main.tf #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| resource "aws_s3_bucket" "data" { | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment B, Order: 2, Line: 1
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. comment
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. index 1
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. index 3
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. index 1
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. index 4 |
||
|
|
||
| # Test | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. index 2
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. index 2 |
||
| # bucket is public | ||
| # bucket is not encrypted | ||
|
|
@@ -15,6 +16,7 @@ resource "aws_s3_bucket" "data" { | |
| } | ||
|
|
||
| resource "aws_s3_bucket_object" "data_object" { | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment C, Order: 3, Line: 18 |
||
|
|
||
| bucket = aws_s3_bucket.data.id | ||
| key = "customer-master.xlsx" | ||
| source = "resources/customer-master.xlsx" | ||
|
|
@@ -25,6 +27,7 @@ resource "aws_s3_bucket_object" "data_object" { | |
| } | ||
|
|
||
| resource "aws_s3_bucket" "financials" { | ||
|
|
||
| # bucket is not encrypted | ||
| # bucket does not have access logs | ||
| # bucket does not have versioning | ||
|
|
@@ -39,7 +42,6 @@ resource "aws_s3_bucket" "financials" { | |
| } | ||
|
|
||
| resource "aws_s3_bucket" "operations" { | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment D, Order: 4, Line: 44
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment D, Order: 4, Line: 44 |
||
|
|
||
| # bucket is not encrypted | ||
| # bucket does not have access logs | ||
| bucket = "${local.resource_prefix.value}-operations" | ||
|
|
@@ -56,6 +58,7 @@ resource "aws_s3_bucket" "operations" { | |
| } | ||
|
|
||
| resource "aws_s3_bucket" "data_science" { | ||
|
|
||
| # bucket is not encrypted | ||
| bucket = "${local.resource_prefix.value}-data-science" | ||
| acl = "private" | ||
|
|
@@ -70,6 +73,7 @@ resource "aws_s3_bucket" "data_science" { | |
| } | ||
|
|
||
| resource "aws_s3_bucket" "logs" { | ||
|
|
||
| bucket = "${local.resource_prefix.value}-logs" | ||
| acl = "log-delivery-write" | ||
| versioning { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated comment 1