Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion main.tf
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
resource "aws_s3_bucket" "data" {

@arielkru arielkru Jun 17, 2021

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated comment 1

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment B, Order: 2, Line: 1

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index 1

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index 3

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index 1

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index 4


# Test

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index 2

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index 2

# bucket is public
# bucket is not encrypted
Expand All @@ -15,6 +16,7 @@ resource "aws_s3_bucket" "data" {
}

resource "aws_s3_bucket_object" "data_object" {

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment C, Order: 3, Line: 18


bucket = aws_s3_bucket.data.id
key = "customer-master.xlsx"
source = "resources/customer-master.xlsx"
Expand All @@ -25,6 +27,7 @@ resource "aws_s3_bucket_object" "data_object" {
}

resource "aws_s3_bucket" "financials" {

# bucket is not encrypted
# bucket does not have access logs
# bucket does not have versioning
Expand All @@ -39,7 +42,6 @@ resource "aws_s3_bucket" "financials" {
}

resource "aws_s3_bucket" "operations" {

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment D, Order: 4, Line: 44

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment D, Order: 4, Line: 44


# bucket is not encrypted
# bucket does not have access logs
bucket = "${local.resource_prefix.value}-operations"
Expand All @@ -56,6 +58,7 @@ resource "aws_s3_bucket" "operations" {
}

resource "aws_s3_bucket" "data_science" {

# bucket is not encrypted
bucket = "${local.resource_prefix.value}-data-science"
acl = "private"
Expand All @@ -70,6 +73,7 @@ resource "aws_s3_bucket" "data_science" {
}

resource "aws_s3_bucket" "logs" {

bucket = "${local.resource_prefix.value}-logs"
acl = "log-delivery-write"
versioning {
Expand Down