Story 18: map SRNE off-grid inverter lifecycle - #4
Open
tushabe wants to merge 2 commits into
Open
Conversation
tushabe
force-pushed
the
agent/story-18-srne-offgrid-state
branch
from
July 24, 2026 10:17
64582d6 to
73a6cb8
Compare
tushabe
marked this pull request as ready for review
July 24, 2026 10:21
arindahills
requested changes
Jul 27, 2026
arindahills
left a comment
Owner
There was a problem hiding this comment.
The OffGridBatteryInverter + StateMachine (machine-state → GridMode, only state 2 validated, transition/unknown states don't claim a mode) is exactly right and respects the live-validation discipline. Read-only + targetGridMode plumbing for story 19 is the right call. One change, same as #2:
ACTIVE_POWER here is also mapped from 0x021B (load power) — same issue: it's the load, not the inverter's power, and phase-A only. Derive it from battery DC power (0x0101 × 0x0102). There is no inverter/ESS power register on this model (verified deep-dive: https://bookstack.nearlyfreeenergy.com/books/product/page/srne-asp48120sh3-modbus-register-map-validated).
tushabe
force-pushed
the
agent/story-17-srne-meters
branch
from
July 27, 2026 09:14
ece8b6d to
c777082
Compare
tushabe
force-pushed
the
agent/story-18-srne-offgrid-state
branch
from
July 27, 2026 09:21
73a6cb8 to
2a3764f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Tracks Nearly-Free-Energy/nfe-modbus-energy-logger#18
Stacked on PR #3; rebase the base to develop after PR #3 merges.