Add RetryUntilSuccessOrExhausted and NonRetryableError to internal/common/util

[mauriceyap]

Add a bounded-retry helper which retries performAction up to maxAttempts times. It calls onExhausted with the last error if the budget runs out. It short-circuits immediately if the error is wrapped in the new NonRetryableError.

This will be used in the ingestion pipeline to decide when to dead-letter a message after retrying it.

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[greptile-apps]

Greptile Summary

Adds a bounded retry utility and sentinel-based non-retryable error handling.

• Retries failed actions up to a configured maximum.
• Stops immediately when an error wraps ErrNonRetryable.
• Reports exhaustion with either the final action error or a descriptive error when no attempts are allowed.
• Adds coverage for success, exhaustion, cancellation, non-retryable errors, and non-positive attempt budgets.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the non-positive budget path now supplies a descriptive error, and the sentinel-based non-retryable API removes the nil-cause dereference path.

Important Files Changed

Filename	Overview
internal/common/util/retry.go	Adds the bounded retry helper, sentinel-based short-circuiting, cancellation handling, and a descriptive zero-attempt exhaustion error; both previously reported defects are resolved.
internal/common/util/retry_test.go	Adds focused tests covering successful retries, exhaustion, cancellation, sentinel wrapping, and non-positive attempt budgets.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Start retry helper] --> B{Context cancelled?}
    B -- Yes --> C[Return false]
    B -- No --> D{Attempts available?}
    D -- No --> E[Call onExhausted]
    D -- Yes --> F[Perform action]
    F --> G{Succeeded?}
    G -- Yes --> H[Return true]
    G -- No --> I{Error is non-retryable?}
    I -- Yes --> E
    I -- No --> J[Call onError]
    J --> B
    E --> K[Return false]

Loading

_{Reviews (7): Last reviewed commit: "ErrNonRetryable" | Re-trigger Greptile}

[nikola-jokic]

Added few suggestions that I think might be useful ☺️

[datadog-armadaproject]

⚠️ Warnings

🚦 1 Pipeline job failed

CI | All jobs succeeded     

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b5dfb49 | Docs | Datadog PR Page | Give us feedback!}