Enable dead-letter topics and jittered backoff for all three ingesters - #5092
Open
mauriceyap wants to merge 4 commits into
Open
Enable dead-letter topics and jittered backoff for all three ingesters#5092mauriceyap wants to merge 4 commits into
mauriceyap wants to merge 4 commits into
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Greptile SummaryThe PR enables bounded, jittered retry behavior and dead-letter publishing for all three ingesters, and ensures each ingester validates its nested Pulsar configuration.
Confidence Score: 5/5The PR appears safe to merge. The previously reported invalid shared validation fixture now leaves
|
| Filename | Overview |
|---|---|
| internal/eventingester/configuration/validation.go | Adds nested Pulsar backoff validation to Event ingester configuration validation. |
| internal/lookoutingester/configuration/validation.go | Adds nested Pulsar backoff validation to Lookout ingester configuration validation. |
| internal/scheduleringester/config.go | Adds nested Pulsar backoff validation to Scheduler ingester configuration validation. |
| config/eventingester/config.yaml | Enables bounded jittered retries and dead-letter publishing for the Event ingester. |
| config/lookoutingester/config.yaml | Enables bounded jittered retries and dead-letter publishing while removing an ignored legacy key. |
| config/scheduleringester/config.yaml | Enables bounded jittered retries and a scheduler-specific dead-letter topic. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
P[Pulsar event topic] --> E[Event ingester]
P --> L[Lookout ingester]
P --> S[Scheduler ingester]
E -->|bounded jittered retries exhausted| ED[events-dead-letter]
L -->|bounded jittered retries exhausted| ED
S -->|bounded jittered retries exhausted| SD[scheduler-events-dead-letter]
Reviews (7): Last reviewed commit: "ugh" | Re-trigger Greptile
|
mauriceyap
force-pushed
the
dlq-ingester-6
branch
from
August 4, 2026 15:42
065b735 to
831a5ee
Compare
mauriceyap
force-pushed
the
dlq-ingester-6
branch
from
August 5, 2026 15:53
1267b50 to
ad46f8f
Compare
Turns the feature on: sets `deadLetterTopic`, `deadLetterMaxAttempts`, `maxBackoffTime`, `backoffRandomizationFactor`, and `backoffMultiplier` in both the production config templates and local-dev configs for the event, lookout, and scheduler ingesters. Each ingester's `Validate()` now also calls `Pulsar.Validate()`. The scheduler ingester additionally gets `DeadLetterMaxAttemptsOverride`/`MaxBackoffTimeOverride` fields so its (more consequential) writes can be tuned independently of the shared `PulsarConfig` block, via a new `effectivePulsarConfig()` that overlays the overrides. `ingester.go` is updated to construct its two pipelines from this effective config rather than `config.Pulsar` directly. Signed-off-by: Maurice Yap <mauriceyap@hotmail.co.uk>
Signed-off-by: Maurice Yap <mauriceyap@hotmail.co.uk>
mauriceyap
force-pushed
the
dlq-ingester-6
branch
from
August 6, 2026 10:07
ad46f8f to
b5ef745
Compare
nikola-jokic
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns the feature on: sets
deadLetterTopic,deadLetterMaxAttempts,maxBackoffTime,backoffRandomizationFactor, andbackoffMultiplierin both the production config templates and local-dev configs for the event, lookout, and scheduler ingesters. Each ingester'sValidate()now also callsPulsar.Validate().