ci: pin reusable workflow references to commit SHAs - #54
Merged
Conversation
Signed-off-by: Ivan Pavlovic <ivan@gr-oss.io>
|
Collaborator
Author
|
Heads-up for reviewers: the failing
The DCO and summary checks pass. Fixing the CodeQL autobuild (e.g. providing explicit build steps instead of relying on autobuild) is a separate follow-up and shouldn't block this SHA-pinning change. |
dave-gantenbein
approved these changes
Jul 29, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pins the two external reusable-workflow references to full commit SHAs (tag kept as a trailing comment):
jenkins-infra/github-reusable-workflows/.github/workflows/maven-cd.yml@v1→7704ec4… # v1jenkins-infra/jenkins-security-scan/.github/workflows/jenkins-security-scan.yaml@v2→da7438f… # v2Why
GitHub's SHA-pinning policy exempts reusable workflows, but a tag ref is still mutable — a compromised/re-pointed
@v1/@v2in the upstream repo would run here with this repo'sGITHUB_TOKENand the Maven publish secrets it's passed. These are third-party (jenkins-infra) dependencies, so this is the highest-value place to pin. Locking to an immutable SHA is defence-in-depth beyond the exempted policy.Scope / safety
uses:lines changed (verified: 0 non-uses:edits).@v2on the security scanner normally floats so its rules stay current. With this pin, Dependabot keeps the SHA (and# v2comment) updated via reviewed bumps instead of blind auto-tracking — controlled updates rather than freezing. If maintainers prefer the scanner to float, they can revert that single line.