-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add Support Shimeta Aiot-rk3588a #8971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ghhccghk
wants to merge
13
commits into
armbian:main
Choose a base branch
from
ghhccghk:pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+729
−0
Draft
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fa16e03
Aiot-rk3588a:Add shimeta-aiot-rk3588a board configuration
ghhccghk fe4c904
Update Aiot-rk3588a board configuration with new boot settings
ghhccghk 0309fd8
Add aiot_rk3588a_defconfig for Aiot-rk3588a board uboot configuration
ghhccghk 7d318d0
Add device tree and update configuration for Aiot-rk3588a board
ghhccghk 751df4a
Add Aiot rk3588a Linux Devices Tree
ghhccghk c4d847a
Disable the DP interface in the Shimeta Aiot-rk3588a Linux device tre…
ghhccghk 8e3be4b
Disable PCIe interfaces in the Aiot-rk3588a device tree,Failure to sh…
ghhccghk fbc6592
Add bootargs, LED, and MCU configuration to Aiot-rk3588a device tree
ghhccghk d1c89a7
Add ADC keys and EDP panel configuration for Aiot-rk3588a device tree
ghhccghk fd86a86
Update Aiot-rk3588a device tree: remove unused includes, update LED G…
ghhccghk 73213f2
Update Aiot-rk3588a device tree: add heartbeat and default-on LED con…
ghhccghk c30548c
Update Aiot-rk3588a device tree: correct GPIO for heartbeat LED, enab…
ghhccghk 1432817
Update Aiot-rk3588a device tree: refine GPIO and I2C configurations
ghhccghk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #Rockchip RK3588 SoC octa core 4-8GB SoC 1Gbe eMMC USB3 USB2 HDMI Type-c LVDS EDP EDPx MIPI MIPI_CAN RS485 RS232 Mic Headphones,4G/5G Module,SATA,HDMI in,Ir Speaker I2C TP,TF Card,FAN | ||
| #Note: Optional 2k EEPROM, PCIe switchable to M.2, speaker output (supports left/right channel output, max. dual 20W/4Ω or 10W/8Ω), eMMC supports 16–128GB. This development board has three versions: V1.1, V1.2, and V1.3. | ||
| BOARD_NAME="Aiot rk3588" | ||
| BOARDFAMILY="rockchip-rk3588" | ||
| BOARD_MAINTAINER="ghhccghk" | ||
| BOOTCONFIG="aiot_rk3588a_defconfig" | ||
| BOOT_SOC="rk3588" | ||
| KERNEL_TARGET="vendor" | ||
| KERNEL_TEST_TARGET="vendor" | ||
| FULL_DESKTOP="yes" | ||
| BOOT_LOGO="desktop" | ||
| BOOT_FDT_FILE="rockchip/rk3588-aiot-rk3588a.dtb" | ||
| IMAGE_PARTITION_TABLE="gpt" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should Shimeta be explicitly mentioned here?
Aiotfeels a hair generic.@coderabbitai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 3575
@tabrisnet, you're absolutely right! Looking at the naming patterns across Armbian board configurations, manufacturer/vendor names are typically included in
BOARD_NAMEfor clear identification. Examples include:"Aiot" (AI + IoT) is indeed quite generic and doesn't uniquely identify this board. Since the filename already includes
shimeta, theBOARD_NAMEshould follow the same pattern. I'd recommend:BOARD_NAME="Shimeta Aiot RK3588"This would be consistent with how other vendors name their boards in the Armbian build system and makes it clear which manufacturer's board this is.
🧠 Learnings used