Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions config/sources/families/rockchip-rk3588.conf
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ family_tweaks_bsp() {
:
}

function extension_prepare_config__enable_mesa_vpu() {
# Auto-enable mesa-vpu for RK3588 GPU acceleration
enable_extension "mesa-vpu"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hasn't it already been enabled in some pre-built images? https://github.com/armbian/os/blob/f31d7b29592e9d0ba01ea2d146e1a58b16a01f7a/userpatches/targets-release-standard-support.yaml#L108

Doing this will disable the Mali kernel driver, but there are also people who don't use Panthor, but instead use libmali for games and computing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that myself but if you look at the extension, it is pretty locked down already. Like minimal images will not be affected at all.
Overall I am not a fan of squeezing this in by default but on the other hand when using a desktop the OOB experience will be better. It is up to the user to switch to libmali or whatever. Some manuals out there like the one from jellyfin would need adjustment to either disable panthor overlay or use minimal image at start.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem enabling this extension only for desktop image builds. For server or minimized images, I'd rather handle it myself.

Yes. The Jellyfin documentation may need updating to tell users who need HDR transcoding to disable the panthor-gpu overlay.

}

# Additional CFLAGS were previously needed to disable certain errors when building vendor U-Boot.
# This is now fixed in Radxa U-Boot sources, but left here (commented out) for reference in case new errors appear in the future.

Expand Down