-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(rockchip-rk3588): Enable mesa-vpu extension for GPU acceleration #8979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
brainwavecoder9
wants to merge
1
commit into
armbian:main
Choose a base branch
from
brainwavecollective:enable-rk3588-gpu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−0
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hasn't it already been enabled in some pre-built images? https://github.com/armbian/os/blob/f31d7b29592e9d0ba01ea2d146e1a58b16a01f7a/userpatches/targets-release-standard-support.yaml#L108
Doing this will disable the Mali kernel driver, but there are also people who don't use Panthor, but instead use libmali for games and computing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about that myself but if you look at the extension, it is pretty locked down already. Like minimal images will not be affected at all.
Overall I am not a fan of squeezing this in by default but on the other hand when using a desktop the OOB experience will be better. It is up to the user to switch to libmali or whatever. Some manuals out there like the one from jellyfin would need adjustment to either disable panthor overlay or use minimal image at start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no problem enabling this extension only for desktop image builds. For server or minimized images, I'd rather handle it myself.
Yes. The Jellyfin documentation may need updating to tell users who need HDR transcoding to disable the panthor-gpu overlay.