Fix -Wunused-private-field when building with clang-cl on Windows#127
Merged
arun11299 merged 1 commit intoarun11299:masterfrom Feb 18, 2026
Merged
Fix -Wunused-private-field when building with clang-cl on Windows#127arun11299 merged 1 commit intoarun11299:masterfrom
-Wunused-private-field when building with clang-cl on Windows#127arun11299 merged 1 commit intoarun11299:masterfrom
Conversation
Contributor
Author
|
Friendly ping @arun11299 :) |
arun11299
approved these changes
Feb 18, 2026
sedited
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Feb 19, 2026
…with clang-cl on Windows 1b36bf0 subprocess: Fix `-Wunused-private-field` for `Child` class on Windows (Hennadii Stepanov) 9f2b338 subprocess: Fix `-Wunused-private-field` for `Popen` class on Windows (Hennadii Stepanov) Pull request description: This PR is a prerequisite for #31507. It resolves `-Wunused-private-field` warnings triggered in `src/util/subprocess.h` when compiling with clang-cl on Windows: ``` D:\a\bitcoin\bitcoin\src\util/subprocess.h(759,10): warning : private field 'parent_' is not used [-Wunused-private-field] [D:\a\bitcoin\bitcoin\build\src\util\bitcoin_util.vcxproj] D:\a\bitcoin\bitcoin\src\util/subprocess.h(760,7): warning : private field 'err_wr_pipe_' is not used [-Wunused-private-field] [D:\a\bitcoin\bitcoin\build\src\util\bitcoin_util.vcxproj] D:\a\bitcoin\bitcoin\src\util/subprocess.h(1038,7): warning : private field 'child_pid_' is not used [-Wunused-private-field] [D:\a\bitcoin\bitcoin\build\src\util\bitcoin_util.vcxproj] ``` Only the second commit has been [submitted](arun11299/cpp-subprocess#127) upstream. The first commit is specific to this repository and not applicable upstream. ACKs for top commit: maflcko: review ACK 1b36bf0 👋 purpleKarrot: ACK 1b36bf0 sedited: ACK 1b36bf0 Tree-SHA512: 1bc0544d769264fa74d2f39150595ee6339af4bca7b7051ecaecbe234c17b643b715e00cfb9302a16ffc4856957f4fa47c216aebf03fec0cd95c387f51bd29a6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below are examples of such warnings:
Ported from bitcoin/bitcoin#34385.