Add commit signature verification - #205
Open
wdantuma wants to merge 3 commits into
Open
Conversation
ascorbic
requested changes
Aug 22, 2026
Owner
There was a problem hiding this comment.
Thanks for doing this – commit signature verification is something I've wanted in the checker for a while, and porting microcosm's logic is the right starting point. Two real bugs (invalid sigs pass; commit DID never compared to the target DID), plus tsc and lockfile failures. Details inline below.
ascorbic
reviewed
Aug 22, 2026
ascorbic
left a comment
ascorbic
left a comment
Owner
There was a problem hiding this comment.
Inline notes for the review above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates @bad-example.com CAR commit object signature verifier code, to also verify the signature of the commit object in a CAR file