Fix lint issues in the packages

[DonOmalVindula]

Purpose

This pull request primarily addresses linting issues across the @asgardeo/browser package and related packages, introduces improved logging practices, and applies various TypeScript and code quality enhancements. The changes aim to standardize logging, improve type safety, and clean up code to align with best practices.

Key changes include:

Linting and Dependency Updates

• Added a changeset and updated dependencies to address and prevent lint issues in multiple packages, including updating TypeScript ESLint dependencies in package.json. [1] [2]
• Updated .eslintignore to exclude the src/__legacy__ directory from linting in the browser package.

Logging Improvements

• Replaced direct console.warn calls with a standardized logger using createPackageComponentLogger in themeDetection.ts, handleWebAuthnAuthentication.ts, and the legacy SPA client, improving consistency and traceability of warnings. [1] [2] [3] [4] F54f47b5L54R48, [5]

TypeScript and Code Quality Enhancements

• Added explicit type annotations and improved type safety in test files and utility functions, such as in navigate.test.ts and handleWebAuthnAuthentication.ts. [1] [2] [3]
• Improved the decorator pattern in helpers/decorators.ts by returning the constructor, removing unnecessary ESLint disables.
• Added ESLint disable comments to prevent cyclic import warnings in main entry points.

Build and Configuration Adjustments

• Refactored and reordered configuration in esbuild.config.mjs for better readability and maintainability, and improved plugin usage for bundling.

Minor Code Cleanups

• Refactored destructuring and type usage for clarity and consistency in several files, such as using destructured classList and adding missing type annotations. [1] [2] [3] [4] [5]

These changes collectively improve code quality, maintainability, and developer experience across the affected packages.

Related Issues

• Fix ESLint lint errors across all packages #365

Related PRs

• N/A

Checklist

• Followed the CONTRIBUTING guidelines.
• Manual test round performed and verified.
• Documentation provided. (Add links if there are any)
• Unit tests provided. (Add links if there are any)

Security checks

• Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines?
• Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?

[asgardeo-github-bot]

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.