Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the agent factory by introducing resolver pattern for checkpointers and prompt providers, replacing direct instantiation and factory functions with centralized resolution logic.
- Introduces
CheckpointerResolverandPromptProviderResolverclasses to handle runtime resolution of checkpointers and prompt providers - Removes the old
create_checkpointerfunction andcreate_prompt_providerfunction in favor of resolver-based approach - Updates agent configuration to include checkpoint type and modifies prompt directory configuration
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/container.py | Replaces checkpointer factory function with resolver and adds prompt provider resolver to dependency injection |
| app/bootstrap/config.py | Adds prompt_root_dir configuration field with default value |
| app/agent/prompt_resolver.py | New resolver class for managing prompt provider creation based on source type |
| app/agent/prompt.py | Updates default prompt directory and removes old factory function |
| app/agent/langgraph/graph.py | Removes TODO comment |
| app/agent/factory.py | Refactors agent creation to use resolver pattern instead of direct instantiation |
| app/agent/config.py | Updates agent config to use checkpoint_type and removes prompt_dir field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.