fix: correct broken README code examples and outdated blog post#4
Merged
Conversation
README: - 'Loading from Python' now uses sys.path + 'from SD_Model import UNetModel' (src/ is not a package), loads EMA shadow with strict=False, and points to inference.py:load_ema_unet as the canonical loader - 'Python API' example now matches generate.py's actual signature (load_model + generate, not the fictional generate_images) docs/blog_post.md: - \u00a76.3: drop the stale 'inference.py doesn't wire --negative' caveat - \u00a77.1: rewrite the post-mortem for the latent clamp — it is now opt-in via clamp_pred_x0=False (default), not monkey-patched - \u00a78: remove 'What I'd Do Differently' items 5 and 6 (both already done) - \u00a710: replace flat file tree with the actual src/ + data_pipeline/ + docs/ + tests/ + scripts/ layout, point to HF Hub for the checkpoint - Final thoughts: drop 'the one clamp at line 736'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes for documentation accuracy:
README:
docs/blog_post.md: