fix: add PHP license header under the PHP tag#34
Open
CommandMaker wants to merge 1 commit intoattilarepka:masterfrom
Open
fix: add PHP license header under the PHP tag#34CommandMaker wants to merge 1 commit intoattilarepka:masterfrom
CommandMaker wants to merge 1 commit intoattilarepka:masterfrom
Conversation
The license was invalidating the PHP file because it would be put before the <?php tag
Owner
|
Hi! That said, this isn’t just a PHP-specific issue. It opens up a broader problem around how headers should be inserted depending on file context (PHP blocks, shebangs, template files, etc.). Because of that, I’d rather handle it with a more general solution instead of merging a language-specific workaround. I’ll revisit this with a proper refactor when I have some time. In the meantime, feel free to keep using your fork/workaround. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I discovered your plugin not long ago and loved it, I wanted to be able to put licence headers for a long time.
But I found a problem : if I use the AddLicenseGPL3 (it should do it with others too) the header would be placed before the <?php tag, causing a syntax problem. I did some kind of dirty fix so I don't know if you'll accept it but it's sufficient for me at least 😆.
Have a nice day !