Refactor Prettier Workflows #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the formatting workflow to be manually triggered to prevent unexpected commits. - Update the CI workflow to use a more robust `npx` command for Prettier linting.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
- Update docs/development.prettier.md to reflect the new manual format workflow and linting check. - Update docs/workflows.ci.md to reflect the simplified npx command. - Rewrite docs/workflows.prettier.md to describe the manual workflow. - Update docs/workflows.md to correctly link and describe the manual workflow.
The previous commit missed running prettier on the updated documentation, causing the linting check to fail. This commit applies the correct formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses issues with the Prettier workflows.
The "format via prettier" workflow has been changed to a manual-only process to prevent it from automatically adding commits to branches. This is now triggered via
workflow_dispatch.The Prettier lint check in the
ci.ymlworkflow has been enhanced to usenpx prettier --check ., which is a more modern and robust way to run the check without requiring a global install. This keeps the automated linting in place while removing the problematic automatic formatting.PR created automatically by Jules for task 1597514435131957419