Repository navigation
Add property-based tests with FsCheck - #61
Merged
Merged
Conversation
For every converter, FsCheck generates random units and values and checks that conversions round-trip, are monotonic, scale linearly, compose through any third unit, leave a unit unchanged when converted to itself and accept unit names in any case. A deliberate bias injected into the conversion makes 22 of the new tests fail; 20 repeated runs with fresh seeds pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds FsCheck property tests for every converter: conversions round-trip, are monotonic, scale linearly, compose through any third unit, leave a unit unchanged when converted to itself, and unit names are accepted in any case.
Checked: a deliberate bias injected into the conversion makes 22 of the 62 new test cases fail, and 20 repeated runs with fresh random seeds all pass. Test-only change plus a changelog and contributing note. It also gives the OpenSSF Scorecard Fuzzing check what it looks for in a .NET project (a property-based testing library).