Negadoctor : Introduce slide film mode#425
Draft
Jiyone wants to merge 4 commits into
Draft
Conversation
f7d80df to
607b125
Compare
* some refactoring.
- invert low white balance settings for slide. - change auto high color balance, black and exposure for slide. - change labels and tooltips text depending on film stock.
|
|
May I suggest that Negadoctor be positioned under the colour tab, rather within its own Film tab, just for the sake of space in the right panel. Of course this may be irrelevant if the Film tab is expected to contain other modules related to film development. |
Collaborator
Author
|
It's an intermediate module, and certainly not a color module. |
d108e91 to
af6cc50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


After testing it for several weeks, I propose this positive film editing mode into Negadoctor.
This feature allows users to edit their scans of slide film and easily restore exposure issues (especially in high and low density color balance).
The GUI adapts based on the selected mode (negative or positive).
Since slide film is not inverted, the color balance settings are reversed between shadows and highlights compared to the negative mode, in order to consistently represent low and high densities across all modes. Parameter names are automatically updated in the Corrections tab, and tooltips are adjusted throughout.
The calculations for the automatic adjustments of the color balance pipettes for high densities, as well as Paper Black and Print Exposure, have been adapted to work correctly in positive mode.
Note:
As for negative film, the user needs to measure the film base with Dmin and the highest density area with Dmax.
In positive mode, Shadow / Highlight color balance are inverted. So in slide film mode, the corrective color balance bias in highlights (offset) should be done first, if any, and then the general color balance is made ideally in shadows (gain).
TODO :
red offsetandred gaininstead ofshadows red offsetandhighlights red gain, orlow red offsetandhigh red gain.