Handle concurrency for credential renewal scenarios. #1039
+214
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchitmehta94
changed the title
| /// Internal utility for synchronizing operations across CredentialsManager instances | ||
| /// and the Authentication API client. This ensures that only one operation is | ||
| /// in flight at a time, preventing concurrency issues when Refresh Token Rotation is enabled. | ||
| final class SynchronizationBarrier { |
Contributor
There was a problem hiding this comment.
there is a Queue barrier used in web auth. can we try to use the same? in web view also its used to block a duplicate transaction
Contributor
Author
There was a problem hiding this comment.
Purpose is different. that was added for preventing ASWebAuthentication crash.
This is more for synchornising requests for renewal in concurrent conditions. https://oktawiki.atlassian.net/wiki/spaces/DXSDK/pages/2883787251/Next+major+of+Auth0.swift+Non-breaking+changes#1.-Make-credenti[%E2%80%A6]rrency-scenarios
sanchitmehta94
changed the title
sanchitmehta94
changed the title
sanchitmehta94
commented
Dec 15, 2025
| 6287D5C92EE30033001E1651 /* OSUnifiedLoggingService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6287D5C62EE30033001E1651 /* OSUnifiedLoggingService.swift */; }; | ||
| 6287D5CA2EE30033001E1651 /* OSUnifiedLoggingService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6287D5C62EE30033001E1651 /* OSUnifiedLoggingService.swift */; }; | ||
| 6287D5CB2EE30033001E1651 /* OSUnifiedLoggingService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6287D5C62EE30033001E1651 /* OSUnifiedLoggingService.swift */; }; | ||
| 62BD27002EEA928F001FC67C /* SynchronizationBarrier.swift in Sources */ = {isa = PBXBuildFile; fileRef = 62BD26FF2EEA928F001FC67C /* SynchronizationBarrier.swift */; }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
More context here: https://oktawiki.atlassian.net/wiki/spaces/DXSDK/pages/2883787251/Next+major+of+Auth0.swift+Non-breaking+changes#1.-Make-credenti[%E2%80%A6]rrency-scenarios
This should fix : auth0/react-native-auth0#1374
https://github.com/auth0/Auth0.swift/blob/889e87357732335804a19c98001337645afb8e6d/Documentation.docc/RefreshTokens.md?plain=1
As per above doc if Devs are calling the Authenticatiin renewAPI() they have to take care of synchronisation but with this PR renewAPI would alos execute one request at a time and will be thread safe
📎 References
🎯 Testing