feature:FGI-1575 Add ability to manage a users connected accounts #60
Conversation
sam-muncke
changed the title
sam-muncke
changed the title
|
Claude finished @kishore7snehil's task —— View job Code Review CompleteTasks
Overall Assessment❌ This PR has critical issues that must be fixed before merging, including incorrect return types, syntax errors in documentation examples, error handling vulnerabilities, and misleading error messages. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| store_options= {"request": request, "response": response} | ||
| ) | ||
| ``` | ||
|
|
There was a problem hiding this comment.
We should add an Error handling Example Section here as I can see the whole document only talks about the happy path.
| connection: str | ||
| access_type: str | ||
| scopes: list[str] | ||
| created_at: str |
There was a problem hiding this comment.
I would request you to restructure the current class structure related to ConnectedAccounts in this file to follow a functional flow. Something like this :
# BASE & SHARED
ConnectedAccountBase(BaseModel)
# ENTITIES (What exists)
ConnectedAccount(ConnectedAccountBase)
ConnectedAccountConnection(BaseModel)
# Connect Operations (How to connect)
ConnectAccountOptions(BaseModel)
ConnectAccountRequest(BaseModel)
ConnectParams(BaseModel)
ConnectAccountResponse(BaseModel)
CompleteConnectAccountRequest(BaseModel)
CompleteConnectAccountResponse(ConnectedAccountBase) #Extends base
# Manage operations
ListConnectedAccountsResponse(BaseModel)
ListConnectedAccountConnectionsResponse(BaseModel)
| self, | ||
| access_token: str, | ||
| connected_account_id: str | ||
| ) -> None: |
There was a problem hiding this comment.
I can't see any docstrings for any of the functions in these files. Is there a specific reason not adding them?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Changes
This PR exposes 3 new methods corresponding to the connected account management endpoints of My Account API:
list_connected_account_connections: List the available connections that a user may use for connected accountslist_connected_accounts: List the connected accounts a user already hasdelete_connected_account: Delete a connected accountReferences
https://auth0team.atlassian.net/browse/FGI-1575
Testing
See included docs for testing instructions
Checklist