Fix/url in readme and ci - #771
Merged
Merged
Conversation
--url is required since #764 — the server exits at boot without it — but these were never swept: the repo's own README (4 blocks, including the Docker quick start and the volume-persistence example), MIGRATION.md (3) and the perf harness (2). Every one of them, copy-pasted, fails with: --url is required (e.g. --url=https://auth.example.com) The perf container publishes 8090:8080, so its --url names 8090 — the address a client actually reaches it on.
Second pass after the README fix. MIGRATION.md had two more blocks (the build/authorizer quickstart and the go run one-liner), and the .env.sample flag-mapping reference omitted --url entirely despite marking --client-id as required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes docs
Which issue(s) does this PR fix?
If this PR affects any API reference documentation, please share the updated endpoint references