Skip to content

fix: forward consent state to analytics tag loader#155

Merged
tstirrat15 merged 1 commit into
mainfrom
fix/tag-consent-signal
Jul 6, 2026
Merged

fix: forward consent state to analytics tag loader#155
tstirrat15 merged 1 commit into
mainfrom
fix/tag-consent-signal

Conversation

@samkim

@samkim samkim commented Jul 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Tag signals now reflect the existing consent cookie instead of defaulting silently

Test plan

  • tsc --noEmit passes
  • npm run lint passes (0 errors)
  • Verified consent signal resolves correctly across all four cases (region x cookie present/absent) via local build
  • Confirm on a preview deployment that the downstream tag actually fires once consent is granted (couldn't fully confirm from this sandbox due to outbound network restrictions unrelated to the code change)

Ensures tag signals reflect the existing consent cookie
instead of defaulting silently, matching opt-in/opt-out handling
already used elsewhere.
@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
playground Ready Ready Preview, Comment Jul 2, 2026 11:11pm

Request Review

@tstirrat15 tstirrat15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tstirrat15
tstirrat15 merged commit 8cec225 into main Jul 6, 2026
5 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants