Polynomial Multiproof Integration#118
Conversation
…into mmp-integration
…into mmp-integration
rac-sri
requested review from
ToufeeqP,
fmiguelgarcia and
markopoloparadox
and removed request for
ToufeeqP and
markopoloparadox
This reverts commit db8ec9a.
| #[cfg(feature = "std")] | ||
| pub mod com; | ||
| #[cfg(feature = "std")] | ||
| #[cfg(any(feature = "std", feature = "serde"))] |
There was a problem hiding this comment.
This doesn't look correct. Why would "serde" enable gridgen?
There was a problem hiding this comment.
avail-rust now requires domain_points inside gridgen in the verify_multiproof method which requires us to enable gridgen, If I do not enable gridgen under feature serde, we are running into compilation errors. Please let me know if this needs to be fixed. cc @rac-sri
There was a problem hiding this comment.
also avail-core is using features runtime and serde in its toml
There was a problem hiding this comment.
This does not make sense. The purpose of serde is to enable serialization and deserialization for existing structures. serde should not be a factor when deciding if a module should be available or not (unless the whole module or file is all about adding types that are forced to use serde).
There was a problem hiding this comment.
the verify multiproof will be moved to avail core anyway, so this is doable.
feat: move verifier inside core
…into mmp-integration
4 participants
No description provided.